xiaoxiang781216 commented on code in PR #11165:
URL: https://github.com/apache/nuttx/pull/11165#discussion_r1392930328
##########
include/nuttx/tls.h:
##########
@@ -309,9 +315,28 @@ uintptr_t task_tls_get_value(int tlsindex);
#elif defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__)
Review Comment:
In this case, we can always use tls_get_info_pid, the macro is to boost the
speed by skipping the syscall.
##########
sched/pthread/pthread_condclockwait.c:
##########
@@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond,
else if (!abstime)
{
- ret = pthread_cond_wait(cond, mutex);
+ ret = nx_pthread_cond_wait(cond, mutex);
Review Comment:
But since both pthread_cond_wait and nxsem_clockwait_uninterruptible are
cancellation point, it's safe to remove
enter_cancellation_point/leave_cancellation_point from this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
