pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1392193610
########## include/nuttx/tls.h: ########## @@ -309,9 +315,28 @@ uintptr_t task_tls_get_value(int tlsindex); #elif defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__) Review Comment: The thing I'm not sure about is how to implement nxnotify_cancellation if some platform uses up_tls_info. nxnotify_cancellation is in the kernel (for now) and it needs to find the TLS area of another thread, I made tls_get_info_pid() for this. up_tls_info can only locate the TLS of the current thread. Another option would be to move nxnotify_cancellation to libc as well, and just sending a signal to the canceled thread instead. This will require moving pthread_cancel to libc though. It might also require adding a new non-maskable signal (SIGCANCELED?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
