xiaoxiang781216 commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1392939538
########## sched/pthread/pthread_condclockwait.c: ########## @@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, else if (!abstime) { - ret = pthread_cond_wait(cond, mutex); + ret = nx_pthread_cond_wait(cond, mutex); Review Comment: But since both pthread_cond_wait and nxsem_clockwait_uninterruptible are cancellation point, it's safe and simple to remove enter_cancellation_point/leave_cancellation_point from this function, if you don't want the nest of cancellation point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org