Xuanwo commented on code in PR #2145: URL: https://github.com/apache/incubator-opendal/pull/2145#discussion_r1179165596
########## bindings/java/src/test/resources/features/binding.feature: ########## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Please link to `bindings/tests` intead. All binding must share the same features. ########## bindings/java/src/main/java/org/apache/opendal/exception/OpenDALErrorCode.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.opendal.exception; + +public enum OpenDALErrorCode { Review Comment: Is it normal to prefix package name in struct name? I perfer to have `ErrorCode`. ########## bindings/java/src/test/java/org/apache/opendal/AsyncStepsTest.java: ########## @@ -61,4 +60,8 @@ public void the_async_file_test_content_length_must_be_13(String fileName, int l @Then("The async file {string} must have content {string}") public void the_async_file_test_must_have_content_hello_world(String fileName, String content) { } + + @Then("The async file {string} should not exist after delete") + public void the_blocking_file_test_should_not_exist_after_delete(String fileName) { Review Comment: This test is not needed. All behavior will be covered by `opendal` itself. Binding only need to make sure itself works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
