Xuanwo commented on code in PR #2145:
URL:
https://github.com/apache/incubator-opendal/pull/2145#discussion_r1181030258
##########
bindings/java/src/test/java/org/apache/opendal/StepsTest.java:
##########
@@ -56,22 +58,26 @@ public void the_blocking_file_test_should_exist(String
fileName) {
public void the_blocking_file_test_entry_mode_must_be_file(String
fileName) {
Metadata metadata = this.operator.stat(fileName);
assertTrue(metadata.isFile());
-
}
@Then("The blocking file {string} content length must be {int}")
public void the_blocking_file_test_content_length_must_be_13(String
fileName, int length) {
Metadata metadata = this.operator.stat(fileName);
-
assertEquals(metadata.getContentLength(), length);
}
@Then("The blocking file {string} must have content {string}")
public void the_blocking_file_test_must_have_content_hello_world(String
fileName, String content) {
String readContent = this.operator.read(fileName);
-
assertEquals(content, readContent);
}
-
+ @Then("Exception should be thrown when read a blocking file {string} that
does not exist")
+ public void the_blocking_file_test_should_not_exist_after_delete(String
fileName) {
Review Comment:
We should not test this.
##########
bindings/java/src/test/resources/features/binding.feature:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+Feature: OpenDAL Java Binding
+
+ Scenario: OpenDAL Blocking Operations
+ Given A new OpenDAL Blocking Operator
+ When Blocking write path "test" with content "Hello, World!"
+ Then The blocking file "test" should exist
+ Then The blocking file "test" entry mode must be file
+ Then The blocking file "test" content length must be 13
+ Then The blocking file "test" must have content "Hello, World!"
+ Then Exception should be thrown when read a blocking file "test" that
does not exist
+
+ Scenario: OpenDAL Async Operations
+ Given A new OpenDAL Async Operator
+ When Async write path "test" with content "Hello, World!"
+ Then The async file "test" should exist
+ Then The async file "test" entry mode must be file
+ Then The async file "test" content length must be 13
+ Then The async file "test" must have content "Hello, World!"
+ Then Exception should be thrown when read a async file "test" that
does not exist
Review Comment:
Please remove this link. `features` must be `symlink` to `bindings/tests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
