Xuanwo commented on code in PR #2145:
URL: 
https://github.com/apache/incubator-opendal/pull/2145#discussion_r1179891162


##########
bindings/java/src/test/java/org/apache/opendal/AsyncStepsTest.java:
##########
@@ -61,4 +60,8 @@ public void 
the_async_file_test_content_length_must_be_13(String fileName, int l
     @Then("The async file {string} must have content {string}")
     public void the_async_file_test_must_have_content_hello_world(String 
fileName, String content) {
     }
+
+    @Then("The async file {string} should not exist after delete")
+    public void the_blocking_file_test_should_not_exist_after_delete(String 
fileName) {

Review Comment:
   > We have to write unit tests for each exception to check.
   
   Looks good to me. They can be scoped inside java bindings.
   
   And please don't test rust core's behavior, we don't want to repeat them in 
all bindings again. For example: `The async file {string} should not exist 
after delete`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to