ShadowySpirits commented on code in PR #2145:
URL:
https://github.com/apache/incubator-opendal/pull/2145#discussion_r1179889712
##########
bindings/java/src/test/java/org/apache/opendal/AsyncStepsTest.java:
##########
@@ -61,4 +60,8 @@ public void
the_async_file_test_content_length_must_be_13(String fileName, int l
@Then("The async file {string} must have content {string}")
public void the_async_file_test_must_have_content_hello_world(String
fileName, String content) {
}
+
+ @Then("The async file {string} should not exist after delete")
+ public void the_blocking_file_test_should_not_exist_after_delete(String
fileName) {
Review Comment:
@Xuanwo I don't have a deep understanding of other language bindings. But in
Java, jni is a dangerous way in which illegal operation will lead to crash jvm.
We have to write unit tests for each exception to check.
My next plan is to refactor the rust code to eliminate `unwrap` and
`except`. And then we can continue to implement features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
