Xuanwo commented on code in PR #3436:
URL:
https://github.com/apache/incubator-opendal/pull/3436#discussion_r1377770681
##########
.github/services/sftp/sftp/action.yml:
##########
@@ -24,7 +24,28 @@ runs:
- name: Setup Sftp
shell: bash
working-directory: fixtures/sftp
- run: docker-compose -f docker-compose-sftp.yml up -d
+ run: |
+ docker-compose -f docker-compose-sftp.yml up -d
+ set +ex
Review Comment:
I don't like this since it's hard for local development. Can we implement in
docker-compose's health check instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]