Zheaoli commented on code in PR #3436:
URL:
https://github.com/apache/incubator-opendal/pull/3436#discussion_r1377797407
##########
.github/services/sftp/sftp/action.yml:
##########
@@ -24,7 +24,28 @@ runs:
- name: Setup Sftp
shell: bash
working-directory: fixtures/sftp
- run: docker-compose -f docker-compose-sftp.yml up -d
+ run: |
+ docker-compose -f docker-compose-sftp.yml up -d
+ set +ex
Review Comment:
> Maybe we can use `docker compose up -d --wait`?
>
> ```shell
> --wait Wait for services to be
> running|healthy. Implies detached mode.
> --wait-timeout int Maximum duration to wait for the
> project to be running|healthy.
> ```
Seems good, I'll make a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
