Zheaoli commented on code in PR #3436:
URL:
https://github.com/apache/incubator-opendal/pull/3436#discussion_r1377794770
##########
.github/services/sftp/sftp/action.yml:
##########
@@ -24,7 +24,28 @@ runs:
- name: Setup Sftp
shell: bash
working-directory: fixtures/sftp
- run: docker-compose -f docker-compose-sftp.yml up -d
+ run: |
+ docker-compose -f docker-compose-sftp.yml up -d
+ set +ex
Review Comment:
> that we have the same setup in both CI and locally.
We already have the same test, just need extra check for automation test in
CI.
Actually, if you want to run the test and compose by using script locally,
you need extra health check to make sure the server is running before running
your test too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
