Zheaoli commented on code in PR #3436:
URL: 
https://github.com/apache/incubator-opendal/pull/3436#discussion_r1377789469


##########
.github/services/sftp/sftp/action.yml:
##########
@@ -24,7 +24,28 @@ runs:
     - name: Setup Sftp
       shell: bash
       working-directory: fixtures/sftp
-      run: docker-compose -f docker-compose-sftp.yml up -d
+      run: |
+        docker-compose -f docker-compose-sftp.yml up -d
+        set +ex

Review Comment:
   Like postgresql
   
   ```text
   ╭─   manjusaka@manjusaka-garuda   ~/Documents/projects/opendal   
jupyter 3.12.0                                                                 
                                                                         
manjusaka/fix-sftp-test *1   23:34:00  
   ╰─ docker ps
   CONTAINER ID   IMAGE          COMMAND                  CREATED         
STATUS                            PORTS                                         
  NAMES
   1e70063710ea   postgres:13    "docker-entrypoint.s…"   8 seconds ago   Up 7 
seconds (health: starting)   0.0.0.0:5432->5432/tcp, :::5432->5432/tcp       
postgresql-postgres-db-1
   729b4e400e39   mongo:latest   "docker-entrypoint.s…"   8 days ago      Up 3 
hours                        0.0.0.0:27017->27017/tcp, :::27017->27017/tcp   
mongo-mongo-1
   ```
   
   The server still in starting status after 7s when `docker compose up -d` 
command finished



##########
.github/services/sftp/sftp/action.yml:
##########
@@ -24,7 +24,28 @@ runs:
     - name: Setup Sftp
       shell: bash
       working-directory: fixtures/sftp
-      run: docker-compose -f docker-compose-sftp.yml up -d
+      run: |
+        docker-compose -f docker-compose-sftp.yml up -d
+        set +ex

Review Comment:
   Like postgresql
   
   ```text
   ╭─   manjusaka@manjusaka-garuda   ~/Documents/projects/opendal   
jupyter 3.12.0                                                                 
                                                                         
manjusaka/fix-sftp-test *1   23:34:00  
   ╰─ docker ps
   CONTAINER ID   IMAGE          COMMAND                  CREATED         
STATUS                            PORTS                                         
  NAMES
   1e70063710ea   postgres:13    "docker-entrypoint.s…"   8 seconds ago   Up 7 
seconds (health: starting)   0.0.0.0:5432->5432/tcp, :::5432->5432/tcp       
postgresql-postgres-db-1
   729b4e400e39   mongo:latest   "docker-entrypoint.s…"   8 days ago      Up 3 
hours                        0.0.0.0:27017->27017/tcp, :::27017->27017/tcp   
mongo-mongo-1
   ```
   
   The server still in starting status after 7s when `docker compose up -d` 
command finished



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to