suyanhanx commented on code in PR #3619:
URL:
https://github.com/apache/incubator-opendal/pull/3619#discussion_r1405787242
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,59 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReaderStream extends Readable {
Review Comment:
I'd keep the reader and writer to preserve the possibility for users to make
their own calls.
> let stream = Readable.from(op.readerSync());
> op.readerSync().pipe(abc);
We can't produce a stream directly. There is also no such usage as `from`.
> Do `Readable` and `Writable` have async support? How could we support them?
The stream of nodejs is asynchronous. This is an event loop model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
