Xuanwo commented on code in PR #3619:
URL:
https://github.com/apache/incubator-opendal/pull/3619#discussion_r1405842131
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,59 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReaderStream extends Readable {
Review Comment:
> The nodejs only has one main thread. So it takes the event loop as its
async model. Every task is executed one by one. Although we are calling
readerSync, it's non-blocking through the event loop. The timing of the call is
scheduled by the runtime.
The point is not about `readerSync`. I'm wondering why we don't have
`BlokcingReadStream` and `ReadSteam` to match with `BlockingReader` and
`Reader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
