suyanhanx commented on code in PR #3619:
URL:
https://github.com/apache/incubator-opendal/pull/3619#discussion_r1405828534
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,59 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReaderStream extends Readable {
Review Comment:
> I'm talking about this API:
https://nodejs.org/api/stream.html#streamreadablefromiterable-options
I know what you mean. However, it requires that the parameter be implemented
as an iterator.
We can't implement that at the moment, `napi-rs` haven't implemented this.
> Make sense. How about following the same pattern like `node::fs` does?
It looks better. But we can't add instance methods to these exported
classes, so it can't be implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
