Xuanwo commented on code in PR #3619:
URL:
https://github.com/apache/incubator-opendal/pull/3619#discussion_r1405823099
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,59 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReaderStream extends Readable {
Review Comment:
> We can't produce a stream directly. There is also no such usage as `from`.
I'm talking about this API:
https://nodejs.org/api/stream.html#streamreadablefromiterable-options
> I'd keep the reader and writer to preserve the possibility for users to
make their own calls.
Make sense. How about following the same pattern like `node::fs` does?
We can have API:
```
let r = op.reader() -> Reader
r.read(buffer)
r.createReadStream() -> ReadStream
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
