Xuanwo commented on code in PR #3619:
URL:
https://github.com/apache/incubator-opendal/pull/3619#discussion_r1405894364
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,89 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReadStream extends Readable {
Review Comment:
I feel like we need `BlockingReadStream` and `ReadStream` for
`BlockingReader` and `Reader`.
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,89 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReadStream extends Readable {
+ constructor(operator, path, options) {
Review Comment:
`ReadStream` should be created by `Reader` so that users can control the
reader behavior like
`op.reader(options_for_reader).createReadStream(options_bypass_to_readable)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
