Xuanwo commented on code in PR #3619:
URL:
https://github.com/apache/incubator-opendal/pull/3619#discussion_r1405921353
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,89 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReadStream extends Readable {
+ constructor(operator, path, options) {
Review Comment:
> we will use the `with_xxx` style API.
Is `with_xxx` style API widely used in nodejs? Maybe we can following the
same API pattern like in python: `op.writer(path, options)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]