suyanhanx commented on code in PR #3619:
URL:
https://github.com/apache/incubator-opendal/pull/3619#discussion_r1405909423
##########
bindings/nodejs/index.js:
##########
@@ -19,9 +19,89 @@
/// <reference types="node" />
+const { Writable, Readable } = require('node:stream')
+
+class ReadStream extends Readable {
+ constructor(operator, path, options) {
Review Comment:
I think this will be an extra method of the `reader`.
Then we will have:
`op.reader(path).createReaderStream(options_bypass_to_readable)` for
controlling reader's behavior
and
`op.createReaderStream(path, options_bypass_to_readable)` for normal using
since we could not create a reader by just passing options, we will use the
`with_xxx` style API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
