yongminkim0501 opened a new pull request, #93:
URL: https://github.com/apache/otava/pull/93
## Overview
This PR converts the 'AnalysisOptions' class to use Pydantic for more
pythonic serialization, as suggested in #78
## Changes
- Changed 'AnalysisOptions' from '@dataclass' to 'pydantic.BaseModel'
- Updated 'to_json()' to use '.dict()' for serialization (Pydantic v1 API)
- Simplified "from_json()' using Pydantic's dict unpacking ('**dict')
- Added "pydantic>=1.9.0, <1.10.0' to dependencies
## Technical Issue
- Used Pydantic v1.9 due to `typing-extensions` version conflict with
`signal-processing-algorithms==1.3.5`
- Using '.dict()' instead of '.model_dump()' (v1.9 doesn't have model_dump,
which is v2 only)
## Testing
- All 68 tests passing
## Future work
- If this approach is approved, I plan to continue converting other classes
with similar serialization patterns to Pydantic.
## Related Issue
Part of #78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
