yongminkim0501 commented on code in PR #93: URL: https://github.com/apache/otava/pull/93#discussion_r2472609567
########## otava/series.py: ########## @@ -32,26 +33,11 @@ ) -@dataclass -class AnalysisOptions: - window_len: int - max_pvalue: float - min_magnitude: float - orig_edivisive: bool - - def __init__(self): - self.window_len = 50 - self.max_pvalue = 0.001 - self.min_magnitude = 0.0 - self.orig_edivisive = False - - def to_json(self): Review Comment: Thanks for the feedback! I'll update the PR to deprecate the to_json() methods instead of removing them. Will commit the changes shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
