henrikingo commented on code in PR #93:
URL: https://github.com/apache/otava/pull/93#discussion_r2469645297
##########
otava/series.py:
##########
@@ -32,26 +33,11 @@
)
-@dataclass
-class AnalysisOptions:
- window_len: int
- max_pvalue: float
- min_magnitude: float
- orig_edivisive: bool
-
- def __init__(self):
- self.window_len = 50
- self.max_pvalue = 0.001
- self.min_magnitude = 0.0
- self.orig_edivisive = False
-
- def to_json(self):
Review Comment:
Until the next release, let's try to keep some superficial backward
compatibility. (After that we will make big changes anyway, so then this can be
removed.)
Could you keep all to_json() functions and make them do something like:
@deprecated
def to_json(self):
return self.dict()
These functions are called by outside code that depends on otava, so this
could ease the pain if upgrading to the next release. (At the same time, note
that we don't promise and don't test for strict backward combatibility at this
stage of the projects lifecycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
