yongminkim0501 commented on code in PR #93: URL: https://github.com/apache/otava/pull/93#discussion_r2484067605
########## otava/series.py: ########## @@ -32,26 +33,11 @@ ) -@dataclass -class AnalysisOptions: - window_len: int - max_pvalue: float - min_magnitude: float - orig_edivisive: bool - - def __init__(self): - self.window_len = 50 - self.max_pvalue = 0.001 - self.min_magnitude = 0.0 - self.orig_edivisive = False - - def to_json(self): Review Comment: Hi @henrikingo, I have a question about the scope of this PR. Converting classes to Pydantic BaseModel requires changing the initialization syntax from positional arguments to keyword arguments. '''python # Before Metric(1, 1.0) # After (Pydantic) Metric(direction=1, scale=1.0) ''' This affects: - Test code (which I can update) - External users who depend on otava I want to make sure I'm following the intended migration path. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
