Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons
for 3 classes in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276050671
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -139,25 +136,13 @@ public String getControllerVipUrl() {
return _controllerConf.generateVipUrl();
}
- public static synchronized void create(PinotHelixResourceManager
helixResourceManager, ControllerConf controllerConf,
+ public PinotLLCRealtimeSegmentManager(PinotHelixResourceManager
helixResourceManager, ControllerConf controllerConf,
Review comment:
I think you can remove the old constructor and only keep this one. (For the
test, use mock)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
