Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons
for 3 classes in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276049917
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -265,8 +275,9 @@ private void setUpPinotController() {
_controllerPeriodicTaskScheduler = new ControllerPeriodicTaskScheduler();
_controllerPeriodicTaskScheduler.init(controllerPeriodicTasks,
_controllerLeadershipManager);
- LOGGER.info("Creating rebalance segments factory");
- RebalanceSegmentStrategyFactory.createInstance(helixParticipantManager);
+ LOGGER.info("Registering rebalance segments factory");
+ _helixResourceManager.registerRebalanceSegmentStrategyFactory(
Review comment:
This line can be moved into the constructor of
RebalanceSegmentStrategyFactory and pass in _helixResourceManager
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
