Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons
for 3 classes in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276047836
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -211,8 +214,8 @@ public void start() {
private void setUpHelixController() {
// Register and connect instance as Helix controller.
LOGGER.info("Starting Helix controller");
- _helixControllerManager = HelixSetupUtils
- .setup(_helixClusterName, _helixZkURL, _instanceId,
_isUpdateStateModel, _enableBatchMessageMode);
+ _helixControllerManager = HelixSetupUtils.setup(_helixClusterName,
_helixZkURL, _instanceId, _isUpdateStateModel,
Review comment:
Have you changed your setting for the code format? Seems this part is
reformatted back and forth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
