Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons
for 3 classes in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276048950
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -254,8 +257,15 @@ private void setUpPinotController() {
// Helix resource manager must be started in order to create
PinotLLCRealtimeSegmentManager
LOGGER.info("Starting realtime segment manager");
- PinotLLCRealtimeSegmentManager
- .create(_helixResourceManager, _config, _controllerMetrics,
_controllerLeadershipManager);
+
+ _pinotLLCRealtimeSegmentManager =
+ new PinotLLCRealtimeSegmentManager(_helixResourceManager, _config,
_controllerMetrics,
+ _controllerLeadershipManager);
+ // TODO: Need to put this inside HelixResourceManager when
ControllerLeadershipManager is removed.
+
_helixResourceManager.registerPinotLLCRealtimeSegmentManager(_pinotLLCRealtimeSegmentManager);
Review comment:
This line can be moved into the constructor of
PinotLLCRealtimeSegmentManager?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
