mayankshriv commented on a change in pull request #4216: PQL -> SQL enhancement
- phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r292117047
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java
##########
@@ -47,75 +61,95 @@ private RequestUtils() {
*/
public static void generateFilterFromTree(FilterQueryTree filterQueryTree,
BrokerRequest request) {
Map<Integer, FilterQuery> filterQueryMap = new HashMap<>();
- MutableInt currentId = new MutableInt(0);
- FilterQuery root = traverseFilterQueryAndPopulateMap(filterQueryTree,
filterQueryMap, currentId);
+ FilterQuery root = traverseFilterQueryAndPopulateMap(filterQueryTree,
filterQueryMap);
filterQueryMap.put(root.getId(), root);
request.setFilterQuery(root);
FilterQueryMap mp = new FilterQueryMap();
mp.setFilterQueryMap(filterQueryMap);
request.setFilterSubQueryMap(mp);
}
+ public static Expression getIdentifierExpression(String identifier) {
Review comment:
Add javadoc to classes and their public methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
