mayankshriv commented on a change in pull request #4216: PQL -> SQL enhancement
- phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r292130438
##########
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java
##########
@@ -103,6 +112,23 @@ public BrokerRequest compileToBrokerRequest(String
expression)
BrokerRequest brokerRequest = new BrokerRequest();
rootNode.updateBrokerRequest(brokerRequest);
+ try {
+ PinotQuery pinotQuery = new PinotQuery();
+ rootNode.updatePinotQuery(pinotQuery);
+ if (VALIDATE_CONVERTER) {
Review comment:
Might be better to write exhaustive tests, than to validate when serving
real traffic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
