mayankshriv commented on a change in pull request #4216: PQL -> SQL enhancement
- phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r292131915
##########
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java
##########
@@ -111,6 +137,64 @@ public BrokerRequest compileToBrokerRequest(String
expression)
}
}
+ private boolean validate(BrokerRequest br1, BrokerRequest br2) throws
Exception {
Review comment:
This could have been a good equals() method on BrokerRequest if it was not
auto-generated by thrift. Also, may be compare() is a better name (I understand
compare usually returns int, not boolean, but might still be better than
validate)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
