mayankshriv commented on a change in pull request #4216: PQL -> SQL enhancement
- phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r292134286
##########
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/SelectAstNode.java
##########
@@ -144,4 +149,27 @@ public void updateBrokerRequest(BrokerRequest
brokerRequest) {
brokerRequest.setSelections(null);
}
}
+
+ @Override
+ public void updatePinotQuery(PinotQuery pinotQuery) {
+ // Set data source
+ DataSource dataSource = new DataSource();
+ dataSource.setTableName(_resourceName);
+ pinotQuery.setDataSource(dataSource);
+ sendPinotQueryUpdateToChildren(pinotQuery);
+ if (_recordLimit != -1) {
Review comment:
What happens if user specifies negative limit? We should also convert that
to default value (unless we are already doing that). What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
