snleee commented on a change in pull request #4454: Add table and segment name
header for segment push
URL: https://github.com/apache/incubator-pinot/pull/4454#discussion_r306525819
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadRestletResource.java
##########
@@ -288,7 +288,15 @@ private SuccessResponse uploadSegment(FormDataMultiPart
multiPart, boolean enabl
throw new UnsupportedOperationException("Unsupported upload type: "
+ uploadType);
}
- String rawTableName = segmentMetadata.getTableName();
+ // Fetch raw table name. Try to derive the table name from the header
and then from segment metadata
Review comment:
Current segment upload API assumes `rawTableName` to be passed. I think that
we should keep it in the same behavior for now.
We can design it correctly when we implement the upload path for the
realtime segments. (e.g. if we open a separate API endpoint for realtime
upload, we can still use `rawTableName`. Or, we can add `tableType` to the
header.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
