snleee commented on a change in pull request #4454: Add table and segment name
header for segment push
URL: https://github.com/apache/incubator-pinot/pull/4454#discussion_r307061494
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/perf/PerfBenchmarkDriver.java
##########
@@ -296,24 +295,6 @@ public void configureTable(String tableName, List<String>
invertedIndexColumns,
_helixResourceManager.addTable(tableConfig);
}
- private void uploadIndexSegments()
Review comment:
`IndexDirectory` is not used in `PerfBenchmarkRunner` which is the wrapper
around `PerfBenchmarkDriver`. We use `dataDir` + `tableName` instead when
loading segments in the beginning.
I removed `IndexDirectory` configuration from `PerfBenchmarkDriverConf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
