snleee commented on a change in pull request #4454: Add table and segment name header for segment push URL: https://github.com/apache/incubator-pinot/pull/4454#discussion_r307062969
########## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/UploadSegmentCommand.java ########## @@ -50,6 +50,10 @@ @Option(name = "-segmentDir", required = true, metaVar = "<string>", usage = "Path to segment directory.") private String _segmentDir = null; + // TODO: make this as a requied field once we deprecate the table name from segment metadata Review comment: fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
