snleee commented on a change in pull request #4454: Add table and segment name 
header for segment push
URL: https://github.com/apache/incubator-pinot/pull/4454#discussion_r306624399
 
 

 ##########
 File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
 ##########
 @@ -521,6 +523,28 @@ public SimpleHttpResponse uploadSegment(URI uri, String 
segmentName, InputStream
     return uploadSegment(uri, segmentName, inputStream, null, null, 
DEFAULT_SOCKET_TIMEOUT_MS);
   }
 
+  /**
 
 Review comment:
   changed to reuse the existing APIs. This involves more changes. Please check 
the recent commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to