Jackie-Jiang commented on a change in pull request #4635: Support ORC files as
data source in segment creation
URL: https://github.com/apache/incubator-pinot/pull/4635#discussion_r327875219
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/PinotDataType.java
##########
@@ -291,27 +304,59 @@ public Double toDouble(Object value) {
INTEGER_ARRAY {
@Override
public Integer[] convert(Object value, PinotDataType sourceType) {
+ if (value instanceof List) {
+ final List list = (List) value;
+ Integer[] res = new Integer[list.size()];
Review comment:
cache the `list.size()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
