Jackie-Jiang commented on a change in pull request #4635: Support ORC files as
data source in segment creation
URL: https://github.com/apache/incubator-pinot/pull/4635#discussion_r328394203
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/PinotDataType.java
##########
@@ -357,6 +358,15 @@ public String toString(Object value) {
public Integer[] toIntegerArray(Object value) {
if (isSingleValue()) {
return new Integer[]{toInteger(value)};
+ } else if (value instanceof List) {
Review comment:
Can you make it as following for readability:
```
if (isSingleValue()) {
...
} else {
if (value instanceof List) {
List valueList = (List) value;
...
} else {
Object[] valueArray = (Object[]) value;
...
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
