Jackie-Jiang commented on a change in pull request #4635: Support ORC files as
data source in segment creation
URL: https://github.com/apache/incubator-pinot/pull/4635#discussion_r328393024
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/DataTypeTransformer.java
##########
@@ -86,9 +87,24 @@ public GenericRow transform(GenericRow record) {
value = new Object[]{defaultNullValue};
}
record.putField(column, value);
+ continue;
} else {
PinotDataType source;
- if (value instanceof Object[]) {
+ if (value instanceof List) {
+ // Multi-valued column
+ List values = (List) value;
+ if (!values.isEmpty()) {
Review comment:
This check should be moved to line 80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
