Jackie-Jiang commented on a change in pull request #4635: Support ORC files as
data source in segment creation
URL: https://github.com/apache/incubator-pinot/pull/4635#discussion_r328394937
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java
##########
@@ -431,7 +437,25 @@ protected void getDataFilePathsHelper(FileSystem
fileSystem, FileStatus[] fileSt
}
protected boolean isDataFile(String fileName) {
- return fileName.endsWith(".avro") || fileName.endsWith(".csv") ||
fileName.endsWith(".json") || fileName
- .endsWith(".thrift") || fileName.endsWith(".parquet");
+ switch (_format) {
+ case AVRO:
+ case GZIPPED_AVRO:
+ return fileName.endsWith(".avro");
+ case PARQUET:
+ return fileName.endsWith(".parquet");
+ case CSV:
+ return fileName.endsWith(".csv");
+ case JSON:
+ return fileName.endsWith(".json");
+ case THRIFT:
+ return fileName.endsWith(".thrift");
+ case ORC:
+ return fileName.endsWith(".orc");
+ case OTHER:
Review comment:
Throw exception for unsupported format?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
