xiangfu0 commented on PR #17269: URL: https://github.com/apache/pinot/pull/17269#issuecomment-4197954139
Addressed all review comments: **Jackie-Jiang:** 1. **ControllerTest.java** — Reverted, no longer in the diff. 2. **DataFetcher.java (caller side check)** — Done. `useDictionary` is computed on the caller side (line 84-85) and passed as constructor parameter. 3. **IndexType.java (IndexConfig vs FieldIndexConfigs)** — Updated. Method signature is `requiresDictionary(FieldSpec, IndexConfig)` taking per-index-type config. 4. **ForwardIndexType createDeserializer** — This override handles legacy FieldConfig deserialization (reading from `fieldConfigList` properties and encoding type). The default `fromIndexes` deserializer only reads from the `indexes` JSON field. Both are merged by `AbstractIndexType.createDeserializer()`. 5. **ForwardIndexType RAW encoding check** — Yes, this is a bug fix. When `encodingType=RAW`, the forward index encoding is explicitly set to RAW. Previously the default DICTIONARY encoding was used even for RAW columns. 6. **ForwardIndexType getFileExtension** — Returns the possible file extensions based on column metadata (sorted/unsorted/raw). `getFileExtension()` returns the primary extension; `getFileExtensions()` returns a list for segment directory lookups. **xiangfu0:** 7. **DataFetcher _forwardIsDictionaryEncoded** — Removed. Only `_useDictionary` remains. 8. **DataFetcher else block** — The else block now handles the shared-dictionary case: when a column has a dictionary but the forward index is raw-encoded, raw values are translated to dict IDs via dictionary lookup (`readDictIdsMVFromRawValues`). This is needed for inverted index queries on raw-forward columns with an explicit dictionary. 9. **BaseIndexHandler import** — Done, using proper import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
