xiangfu0 commented on code in PR #17269:
URL: https://github.com/apache/pinot/pull/17269#discussion_r3057665258
##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -312,13 +316,22 @@ private class ColumnValueReader implements AutoCloseable {
final Dictionary _dictionary;
final DataType _storedType;
final boolean _singleValue;
+ final boolean _useDictionary;
+ final boolean _forwardIsDictionaryEncoded;
Review Comment:
Already addressed: _forwardIsDictionaryEncoded was removed. The current code
only has _useDictionary.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/BaseIndexHandler.java:
##########
@@ -112,10 +112,14 @@ protected ColumnMetadata
createForwardIndexIfNeeded(SegmentDirectory.Writer segm
FieldIndexConfigs fieldIndexConfig = _fieldIndexConfigs.get(columnName);
boolean dictionaryEnabled =
fieldIndexConfig.getConfig(StandardIndexes.dictionary()).isEnabled();
ForwardIndexConfig forwardIndexConfig =
fieldIndexConfig.getConfig(StandardIndexes.forward());
+ boolean dictionaryBasedForwardIndex =
+ forwardIndexConfig.getForwardIndexEncoding() ==
org.apache.pinot.segment.spi.creator.IndexCreationContext
Review Comment:
Fixed: the import for IndexCreationContext is now added at the top of
BaseIndexHandler.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
