xiangfu0 commented on code in PR #17269:
URL: https://github.com/apache/pinot/pull/17269#discussion_r3057668680
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexType.java:
##########
@@ -166,6 +166,14 @@ public String getPrettyName() {
return INDEX_DISPLAY_NAME;
}
+ @Override
+ protected ColumnConfigDeserializer<ForwardIndexConfig> createDeserializer() {
Review Comment:
This createDeserializer override was removed in a subsequent refactor. The
current diff no longer contains this change.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexType.java:
##########
@@ -203,6 +211,9 @@ private boolean isDisabled(Map<String, String> props) {
private ForwardIndexConfig createConfigFromFieldConfig(FieldConfig
fieldConfig) {
ForwardIndexConfig.Builder builder = new ForwardIndexConfig.Builder();
builder.withCompressionCodec(fieldConfig.getCompressionCodec());
+ if (fieldConfig.getEncodingType() == FieldConfig.EncodingType.RAW) {
Review Comment:
This createConfigFromFieldConfig change was removed in a subsequent
refactor. The current diff no longer contains it.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexType.java:
##########
@@ -235,19 +246,22 @@ protected IndexReaderFactory<ForwardIndexReader>
createReaderFactory() {
return ForwardIndexReaderFactory.getInstance();
}
- public String getFileExtension(ColumnMetadata columnMetadata) {
+ public List<String> getFileExtension(ColumnMetadata columnMetadata) {
Review Comment:
The getFileExtension change returning List<String> was removed in a
subsequent refactor. The current diff no longer contains it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
