xiangfu0 commented on code in PR #17269:
URL: https://github.com/apache/pinot/pull/17269#discussion_r3062627920
##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -333,13 +338,23 @@ private ForwardIndexReaderContext getReaderContext() {
void readDictIds(int[] docIds, int length, int[] dictIdBuffer) {
Tracing.activeRecording().setInputDataType(_storedType, _singleValue);
- _reader.readDictIds(docIds, length, dictIdBuffer, getReaderContext());
+ ForwardIndexReaderContext readerContext = getReaderContext();
+ if (_useDictionary) {
+ _reader.readDictIds(docIds, length, dictIdBuffer, readerContext);
+ } else {
+ Preconditions.checkState(_dictionary != null, "Dictionary must be
present for raw forward index");
Review Comment:
_dictionary can be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
