xiangfu0 commented on code in PR #18165:
URL: https://github.com/apache/pinot/pull/18165#discussion_r3067710057
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/HashFunctions.java:
##########
@@ -229,6 +253,14 @@ public static int fnv1Hash32(byte[] input) {
return FnvHashFunctions.fnv1Hash32(input);
}
+ /**
+ * Computes 32-bit FNV-1 hash using the partition-expression friendly name.
+ */
+ @ScalarFunction(names = {"fnv1_32"})
Review Comment:
add to `names` for ScalarFunction `fnv1Hash32`
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/HashFunctions.java:
##########
@@ -119,6 +127,14 @@ public static int murmurHash2(byte[] input) {
return MurmurHashFunctions.murmurHash2(input);
}
+ /**
+ * Computes 32-bit MurmurHash2 of the given byte array using the
partition-expression friendly name.
+ */
+ @ScalarFunction
Review Comment:
define murmur2 in `ScalarFunction` names for `murmurHash2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
