haibow commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r343509170
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -148,6 +148,10 @@ public long getLatestIngestionTimestamp() {
_segmentPartitionConfig = config.getSegmentPartitionConfig();
_nullHandlingEnabled = config.isNullHandlingEnabled();
+ // Ensure that the schema has the virtual columns added
Review comment:
Now virtual columns are only added to immutable segments, although in
mutable segments there are logics in `getDataSource` for virtual columns. So
adding virtual columns to mutable segments too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
