haibow commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r343509964
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -472,10 +476,8 @@ public SegmentMetadata getSegmentMetadata() {
public ColumnDataSource getDataSource(String columnName) {
FieldSpec fieldSpec = _schema.getFieldSpecFor(columnName);
if (fieldSpec.isVirtualColumn()) {
- VirtualColumnContext virtualColumnContext =
- new VirtualColumnContext(NetUtil.getHostnameOrAddress(),
getSegmentName(), columnName, _numDocsIndexed + 1);
- VirtualColumnProvider virtualColumnProvider =
-
VirtualColumnProviderFactory.buildProvider(_schema.getFieldSpecFor(columnName).getVirtualColumnProvider());
+ VirtualColumnContext virtualColumnContext = new
VirtualColumnContext(fieldSpec, _numDocsIndexed);
Review comment:
I'm not sure why `_numDocsIndexed + 1` is used - it's causing
`MutableSegmentImplTest` to fail after adding virtual columns to mutable
segments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
