haibow commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r349842523
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplTest.java
##########
@@ -139,7 +145,9 @@ public void testDataSourceForSVColumns() {
int actualDictId = actualSVIterator.nextIntVal();
int expectedDictId = expectedSVIterator.nextIntVal();
- Assert.assertEquals(actualDictionary.get(actualDictId),
expectedDictionary.get(expectedDictId));
+ // Only allow the default segment name to be different
+ if
(!column.equals(CommonConstants.Segment.BuiltInVirtualColumn.SEGMENTNAME))
Review comment:
added the braces. I abandoned the segment name change. Hope this will make
it a bit easier to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
