haibow commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r345446565
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/virtualcolumn/SingleStringVirtualColumnProvider.java
##########
@@ -52,8 +53,7 @@ public Dictionary buildDictionary(VirtualColumnContext
context) {
public ColumnMetadata buildMetadata(VirtualColumnContext context) {
ColumnMetadata.Builder columnMetadataBuilder =
super.getColumnMetadataBuilder(context);
-
columnMetadataBuilder.setCardinality(1).setHasDictionary(true).setHasInvertedIndex(true)
-
.setFieldType(FieldSpec.FieldType.DIMENSION).setDataType(FieldSpec.DataType.STRING).setSingleValue(true)
+
columnMetadataBuilder.setCardinality(1).setHasDictionary(true).setHasInvertedIndex(true).setSingleValue(true)
Review comment:
Common metadata are moved to `BaseVirtualColumnProvider`
(`setFieldType(fieldSpec.getFieldType()).setDataType(fieldSpec.getDataType()`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
