Jackie-Jiang commented on code in PR #18837:
URL: https://github.com/apache/pinot/pull/18837#discussion_r3461884163
##########
config/checkstyle.xml:
##########
@@ -357,4 +357,8 @@
<property name="format" value="StringUtils\.replace\("/>
<property name="message" value="StringUtils.replace() is deprecated. Use
Strings.CS.replace() instead."/>
</module>
+ <module name="RegexpSingleline">
Review Comment:
Suggest not banning this completely. It make sense to use it when element is
`null`. As long as we remove most usage of it, AI should be able to use
`List.of()` when applicable.
We can also replace usages of `Collections.singleton()` and
`Collections.singletonMap()`.
We can remove usage of `Collections.emptyList()/Set()/Map()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
