xiangfu0 commented on code in PR #18837:
URL: https://github.com/apache/pinot/pull/18837#discussion_r3462439358
##########
config/checkstyle.xml:
##########
@@ -357,4 +357,8 @@
<property name="format" value="StringUtils\.replace\("/>
<property name="message" value="StringUtils.replace() is deprecated. Use
Strings.CS.replace() instead."/>
</module>
+ <module name="RegexpSingleline">
Review Comment:
Addressed. I removed the hard Checkstyle ban, replaced the remaining
`Collections.singleton()`, `Collections.emptyList()`, `Collections.emptySet()`,
and `Collections.emptyMap()` usages with `Set.of()`, `List.of()`, and
`Map.of()` where applicable, and kept null-preserving cases explicit instead of
banning the old APIs outright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
