xiangfu0 commented on code in PR #18837:
URL: https://github.com/apache/pinot/pull/18837#discussion_r3463377739
##########
config/checkstyle.xml:
##########
@@ -357,4 +357,8 @@
<property name="format" value="StringUtils\.replace\("/>
<property name="message" value="StringUtils.replace() is deprecated. Use
Strings.CS.replace() instead."/>
</module>
+ <module name="RegexpSingleline">
Review Comment:
Follow-up update: kept the Checkstyle guard targeted to
`Collections.emptyList` and `Collections.emptyMap` (including method
references), while leaving
`Collections.singletonList`/`Collections.singletonMap` unblocked so
null-preserving test/compat cases remain possible. Agent docs and C7.12 now
call out that distinction explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
